Re: [PATCH 10/11] avoid kobject name conflict with differentnamespaces

From: Greg KH
Date: Wed May 07 2008 - 15:14:54 EST


On Wed, May 07, 2008 at 11:49:19AM -0700, Eric W. Biederman wrote:
> Unless there is another path I think placing an additional pointer in
> kobj_type so we can find it through ktype is the simplest solution.
> Although using the kset is also sane.

Ick, ick, ick :)

> The easiest and most trivially correct thing to do would be to simply
> remove the unnecessary check from kobject_rename. We perform the
> check at the upper levels in the network anyway. And kobject_rename
> is only used by the network stack.

Wireless uses it also for some things, and it requires that it fail if a
duplicate is found. I thought that s390 also used it, but I don't see
that usage in the tree anymore, perhaps they switched to something else.

good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/