Re: [BUG]:WARNING: at arch/x86/kernel/rtc.c:122 in 2.6.26-rc1

[Andi Kleen]

Thomas Gleixner wrote:
> On Thu, 8 May 2008, Andi Kleen wrote:
>>> May  7 21:52:04 kernel: [4294896.091827] Extended CMOS year: 2000
>>> May  7 21:52:04 kernel: [4294896.091827] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
>>> May  7 21:52:04 kernel: [4294896.091827] Back to C!
>>> May  7 21:52:04 kernel: [4294896.091827] Extended CMOS year: 2000
>> If the data is read correctly (and it looks like it) then just the bit
>> is wrong and we should ignore it I guess. So just remove the
>> WARN_ON_ONCE()?
> 
> You put a printk there in the first place :) I changed it to
> WARN_ON_ONCE as one line printks are more likely to be ignored.

Ignoring would have been fine here, but point taken.

> I'm all for it to remove the while BCD check, which is hardcoded to
> ALWAYS_BCD = 1 since linux 1.0.

Fine for me.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/