Re: [Patch 2/9] fs/exec.c: fix resource leaks and wrong goto's

From: Al Viro
Date: Sat May 10 2008 - 15:17:11 EST


On Thu, May 08, 2008 at 09:52:27PM +0800, WANG Cong wrote:
> When ->load_binary() successed, free_arg_pages() should be called to
> clean the pages allocated by copy_strings_kernel() within it.

Eh? Success or not, free_arg_pages() will eventually be called by do_execve();
so what problem are you trying to solve?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/