Re: [PATCH 2/3] x86: janitor work in bugs.c

[Andi Kleen]

Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> writes:
>  	if (!boot_cpu_data.hard_math) {
>  #ifndef CONFIG_MATH_EMULATION
> -		printk(KERN_EMERG "No coprocessor found and no math emulation present.\n");
> +		printk(KERN_EMERG "No coprocessor found and no math "
> +			"emulation present.\n");

This means if someone gets this message and wants to grep for it they won't
find it. Bad bad bad.

We had a discussion recently that wrapping printk format strings
is a bad idea. Don't do it please.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/