Re: + wireless-fix-iwlwifi-unify-init-driver-flow.patch added to-mm tree

[David Miller]

From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Tue, 13 May 2008 21:05:50 -0700

> Subject: wireless: fix "iwlwifi: unify init driver flow"
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> 
> drivers/net/wireless/iwlwifi/iwl-core.c: In function 'iwlcore_init_geos':
> drivers/net/wireless/iwlwifi/iwl-core.c:323: error: implicit declaration of function 'iwlcore_init_ht_hw_capab'
> 
> This (or something like it) should be folded into the base patch to avoid
> breaking bisection, please.
> 
> Cc: Ron Rindjunsky <ron.rindjunsky@xxxxxxxxx>
> Cc: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> Cc: John W. Linville <linville@xxxxxxxxxxxxx>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Andrew, you have to figure out what we're supposed to do here.

If I "fold in the patch" to avoid breaking bisection, I have to
completely rebase my tree screwing up everyone of my downstream
developers.

Or is this some patch I'm supposed to remember to fold in several
months from now, to some random changeset out of thousands, when the
merge window opens?

Neither option is tenable, and the headaches of neither are
worth it purely for the sake of bisection.

My solution to the bisection problem is to wait a day before pushing
out usually, it's a best effort thing.  I do as many sanity builds as
I can, and we also hope that someone during that day might solve the
problem independantly and post a fix.  That way I can fix it in my
tree locally before the tree goes public.

And I think this is the most reasonable approach.

Once I push something to my public tree, quite frankly, it's the real
deal, it's staying there, and it's a part of the permanent record.
And therefore, we'll put fixes on top.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/