Re: [PATCH 2/3] x86: janitor work in bugs.c

From: H. Peter Anvin
Date: Wed May 14 2008 - 00:45:32 EST


Joe Perches wrote:
On Tue, 2008-05-13 at 23:09 +0200, Andi Kleen wrote:
We had a discussion recently that wrapping printk format strings
is a bad idea. Don't do it please.

I don't know that there was a resolution either.
http://lkml.org/lkml/2008/2/22/143

If there was one, there's a lot of possible changes.

$ grep -rP --include=*.[ch] "printk.*\"\s*$\s*\"" * | wc -l
13276

divide by 2, there are more than 6K split source line printks


Perhaps a better idea would be to write a script to grep for strings.

-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/