Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4

From: Andrew Morton
Date: Wed May 14 2008 - 05:57:55 EST


On Wed, 14 May 2008 11:51:17 +0200 Benjamin Thery <benjamin.thery@xxxxxxxx> wrote:

> > uninlining sysfs_rename_dir() would be a sensible solution.
>
> It is inlined only when CONFIG_SYSFS=n. When sysfs is enabled
> sysfs_rename_dir() is compiled from fs/sysfs/dir.c
>
> Uninlining it will require us to find an appropriate .c file to put it
> in: we can't put it in fs/sysfs/dir.c. It is not built if CONFIG_SYSFS
> is disabled.

Well yes, that's the problem. I stuck it in lib/kobject.c but ugh.

I guess we could make it a macro and quickly run away.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/