Re: [rtc-linux] Re: [PATCH] add support for ST M41T94 SPI RTC

[Kim B. Heino]

Hi Alessandro,

>  can you check that you really require
>  all of those #includes ?

You're right, I don't. Fixed.

> > +struct m41t94 {
> > +	struct rtc_device *rtc;
> > +	u8 buf[8]; /* Burst read cmd + 7 registers */
> > +};
>  why are you keeping the buffer here?

rtc-max6902.c did that too... Fixed.

>  the choice is up to you, but I'd use the century bit if there
>  is one.

Ok, I'll add support for century bit. Again there are some other 
rtc-drivers (like rtc-m41t80.c and rtc-ds1307.c) not using it.

>  no spaces between MODULE_XXX and the ( please.

Fixed.

I'll wait for more comments and post a new patch tomorrow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/