Re: [PULL] v9fs bug fixes and documentation updates for 2.6.26

[Eric Van Hensbergen]

On Wed, May 14, 2008 at 9:40 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>
> On Wed, 14 May 2008, Eric Van Hensbergen wrote:
>>
>> Jim Meyering (1):
>>       fs/9p/v9fs.c (v9fs_parse_options): Handle kstrdup and
>> match_strdup failure. Now that this function can fail, return an int,
>> diagnose other option-parsing failures, and adjust the sole caller:
>> (v9fs_session_init): Handle kstrdup failure. Propagate any new
>> v9fs_parse_options failure "up".
>
> Grr. Somebody isn't following the nice rules we have and that git
> encourages: make a commit message be a nice "one-line header" with the
> more complete explanation separated by an empty line (and with nice
> line-breaks etc).
>

Sorry boss.  I had a nagging feeling I was doing the wrong thing about
not diving in and fixing that comment.  Not sure where I messed up
applying the email, but if I see that sort of thing in the future I'll
edit it by hand.

>
> There are other commits that don't follow the rules, btw: you've applied
> patches from others that have the rigth Sign-off's from the authors, but
> you should sign off yourself, not just ack them. By actually taking that
> thing and committing it, you're doing more than ack'ing somebody elses
> work.
>

Sure, long term misunderstand on my part.  Thanks for clearing this
up, I'll be sure to properly sign off in the future.

          -eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/