Re: [PATCH] USB: add Sensoray 2255 v4l driver

From: Mauro Carvalho Chehab
Date: Fri May 16 2008 - 14:18:16 EST


Dean,

On Fri, 16 May 2008 08:57:15 -0700
dean <dean@xxxxxxxxxxxx> wrote:

> Hi Oliver,
>
> Just to be clear. You mean fixing the loading issues(ugly msleep,
> etc...) that Mauro mentioned, not the YUV formats(which seem unrelated)?
>
> Would it be ok to have just 422P and greyscale in the driver for now if
> we can't get a firmware update in a reasonable timeframe? It's certainly
> not ideal, but we could direct our customers to the libraries, at least
> until we get a proper HW fix.

Feature regression is something that shouldn't happen. If we add the driver
with a color conversion inside, we should somehow keep this feature available
on newer versions. That's said, I don't see any issue if the later versions do
this implementation inside hardware/firmware, since the end result is that the
driver will keep supporting those standards.

>From my side, I'm ok on having this color conversion for a short timeframe (one
or two kernel releases), if you are sure that those features will be present
on the next firmwares.

The better is to mark the driver as EXPERIMENTAL, at Kconfig.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/