Re: 2.6.26-rc2-mm1: high speed something

From: Greg KH
Date: Fri May 16 2008 - 18:01:47 EST


On Fri, May 16, 2008 at 02:31:08PM -0700, Andrew Morton wrote:
> On Sat, 17 May 2008 02:17:49 +0400
> Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>
> > > linux-next.patch
> >
> > That's terse. ;-)
>
> well, it's a git tree, and all that this implies. The git URL is
> right at the top of linux-next.patch.
>
> > Who is responsible for something called "Option High Speed Mobile
> > Devices"?
>
> The full changelog is contained in linux-next.patch. Searching it for
> "Option" quickly leads to
>
> commit a50a26ba350a5f32ec6481c85b938fc7fb476671
> Author: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Date: Mon Apr 14 11:41:16 2008 -0700
>
> USB: add option hso driver
>
> This driver is for a number of different Option devices. Originally
> written by Option and Andrew Bird, but cleaned up massivly for
> acceptance into mainline by me (Greg).
>
> TODO:
> - remove proc files and move to debugfs
> - review network interfaces
> - add better changelog information
> - Use netif_msg_ for the message level rather than module parameter
> - net_device_stats are now available in dev->stats
>
> Many thanks to the following for their help in cleaning up the driver by
> providing feedback and patches to it:
> - Paulius Zaleckas <paulius.zaleckas@xxxxxxxxxxxx>
> - Oliver Neukum <oliver@xxxxxxxxxx>
> - Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
>
>
> Cc: Andrew Bird <ajb@xxxxxxxxxxxxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Cc: Filip Aben <f.aben@xxxxxxxxxx>
> Cc: Paulius Zaleckas <paulius.zaleckas@xxxxxxxxxxxx>
> Cc: Oliver Neukum <oliver@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
>
> > It's using create_proc_read_entry() interface, so should be switched
> > to seq_files before merging.

The whole proc interface is gone, so no need for that.

> > And "procfs" module parameter is plain stupid, sorry.

That parameter is gone, see the patches posted to lkml for an updated
version.

thanks,

greg "i'm stupid" k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/