Re: [PATCH 1/5] x86: Move es7000_plat out of mpparse.c

From: Alexey Starikovskiy
Date: Fri May 16 2008 - 19:31:47 EST


Ingo,
I seem to have lost the track of changes... Why the ifdef LOCAL_APIC was switched to MPPARSE?

Reverting it back makes the error to go away...

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 089ddfa..c86bda7 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -12,7 +12,7 @@
#include <asm/mpspec.h>
#include <asm/apicdef.h>

-#ifdef CONFIG_X86_MPPARSE
+#ifdef CONFIG_X86_LOCAL_APIC
unsigned int num_processors;
unsigned disabled_cpus __cpuinitdata;


Ingo Molnar wrote:
the build failure is:

arch/x86/kernel/built-in.o: In function `init_apic_mappings':
: undefined reference to `boot_cpu_physical_apicid'
arch/x86/kernel/built-in.o: In function `init_apic_mappings':
: undefined reference to `boot_cpu_physical_apicid'
arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
: undefined reference to `boot_cpu_physical_apicid'
arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
: undefined reference to `boot_cpu_physical_apicid'
arch/x86/kernel/built-in.o: In function `APIC_init_uniprocessor':
: undefined reference to `phys_cpu_present_map'
arch/x86/kernel/built-in.o: In function `setup_local_APIC':
: undefined reference to `phys_cpu_present_map'
arch/x86/kernel/built-in.o: In function `generic_processor_info':
: undefined reference to `phys_cpu_present_map'
arch/x86/kernel/built-in.o: In function `generic_processor_info':
: undefined reference to `num_processors'
arch/x86/kernel/built-in.o: In function `generic_processor_info':
: undefined reference to `num_processors'
arch/x86/mach-visws/built-in.o: In function `find_smp_config':
: undefined reference to `boot_cpu_physical_apicid'
arch/x86/mach-visws/built-in.o: In function `find_smp_config':
: undefined reference to `phys_cpu_present_map'


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/