Re: [Bonding-devel] [patch] bondig - arp_interval with low value => Oops.

[Jay Vosburgh]

Joe Eykholt <jre@xxxxxxxxxxxxxxxx> wrote:

>Nicolas 2P wrote:
[...]
>> @@ -2837,7 +2837,7 @@
>> 
>>         read_lock(&bond->lock);
>> 
>> -       delta_in_ticks = (bond->params.arp_interval * HZ) / 1000;
>> +       delta_in_ticks = msecs_to_jiffies(bond->params.arp_interval * HZ);
>
>This seems like it should be just:
>
>	delta_in_ticks = msecs_to_jiffies(bond->params.arp_interval);

	Yes.  I've corrected this already in my copy (which I'll be
posting momentarily).

>Same for the other changes?

	The other two instances were correct, only the last change had
the extra "* HZ".

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html