Re: [RFC] x86: merge nmi_32-64 to nmi.c

From: Jeremy Fitzhardinge
Date: Sun May 18 2008 - 03:26:22 EST


Thomas Gleixner wrote:
Definitely, but we should do it at the Kconfig level which allows us
to have integer defines as well, so we end up with something like:

static inline unsigned int get_nmi_count(int cpu)
{
return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
}

Unfortunately that doesn't work because when CONFIG_X86_64 isn't defined it doesn't expand to 0. It would be nice if CONFIG_* expanded to 0/1, but we'd need to change all the #ifdef CONFIG_* to #if CONFIG_*...

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/