Re: [PATCH] Add support for HTC Shift Touchscreen

[Pekka Enberg]

On Sat, May 17, 2008 at 7:38 PM, Pau Oliva Fora <pau@xxxxxxxxxx> wrote:
>>> +struct input_dev *htcpen_dev;
>>
>> Why are you not using isa_register_driver() instead?
>
> I have no specifications from the manufacturer, so don't know how to
> properly prove the device, etc.

You can still use isa_register_driver() which is nicer IMHO.

On Sat, May 17, 2008 at 7:38 PM, Pau Oliva Fora <pau@xxxxxxxxxx> wrote:
>>> +       printk(KERN_INFO "htcpen: module inserted\n");
>>> +
>>> +       inb_p(HTCPEN_PORT0);
>>
>> So there's no way to probe the existence of this device?
>
> I can add a minimal sanity check if that is a must, but I don't have
> a datasheet and contacting HTC did not help.

Well, you probably want distributions to be able to enable this by
default so any kind probing is helpful, yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/