Re: [PATCH] decodecode: use cross-compiler/toolchain if defined

[Vegard Nossum]

On Mon, May 19, 2008 at 9:02 PM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Mon, May 12, 2008 at 03:52:42PM +0200, Vegard Nossum wrote:
>>
>> From 75166add6121dbda4fad2e197d4fe6525dee580c Mon Sep 17 00:00:00 2001
>> From: Vegard Nossum <vegard.nossum@xxxxxxxxx>
>> Date: Mon, 12 May 2008 15:36:38 +0200
>> Subject: [PATCH] decodecode: use cross-compiler/toolchain if defined
>>
>> From the Makefile: "CROSS_COMPILE specify [sic] the prefix used for all
>> executables used".
>>
>> This is also very useful for decoding oopses on other archs than the
>> native one, so it seems natural to have it in the decodecode script as
>> well.
>
> I agree with the intent of this patch.
> But as it is my experience that most people use
> CROSS_COMPILE on the commandline and not as an
> environmnet variable most will not benefit from this patch.

I do use it on the command line too, it just has to come in front of
the 'make' command:

CROSS_COMPILE=x86_64-linux-unknown-gnu- make

> We should as a minimum document this use of decodecode where we
> document its usage today (oops-tracing.txt).
>
> We could also make it a Makefile target thus it is a bit
> more natural to supply the typical Makefile parameters?
>
> Please rework one way or the other.

I can try to do both those, however I don't see how this patch fails
to be an improvement in any case.

Thanks for the feedback.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/