Re: [PATCH 1/1] avr32/pata: avoid unnecessary memset (updated aftercomments)

[Jeff Garzik]

Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
>
> Hi, here is a patch against linux/drivers/ata/pata_at32.c which :
> 	
> 1) Remove an explicit memset(.., 0, ...) to a variable allocated with
> kzalloc (i.e. 'info').
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@xxxxxxxxxx>
> Acked-by: Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx>
>
> ---
>
> --- linux/drivers/ata/pata_at32.c	2008-04-17 04:49:44.000000000 +0200
> +++ linux/drivers/ata/pata_at32.c.cj	2008-05-12 23:07:10.000000000 +0200
> @@ -329,8 +329,6 @@ static int __init pata_at32_probe(struct
>  	if (!info)
>  		return -ENOMEM;
>  
> -	memset(info, 0, sizeof(struct at32_ide_info));
> -
>  	info->irq = irq;
>  	info->cs  = board->cs;

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/