PATCH] Replace a printk + WARN_ON() to a WARN()
From: Arjan van de Ven
Date: Tue May 20 2008 - 09:37:04 EST
From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
Subject: [PATCH] Replace a printk + WARN_ON() to a WARN()
Replace a printk+WARN_ON() by a WARN(); this increases the
chance of the string making it into the bugreport
(eg it goes inside the ---[ cute here ]--- section)
Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
---
kernel/irq/manage.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 46d6611..e296f67 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -224,9 +224,7 @@ int set_irq_wake(unsigned int irq, unsigned int on)
set_wake = NULL;
} else {
if (desc->wake_depth == 0) {
- printk(KERN_WARNING "Unbalanced IRQ %d "
- "wake disable\n", irq);
- WARN_ON(1);
+ WARN(1, "Unbalanced IRQ %d wake disable\n", irq);
} else if (--desc->wake_depth == 0)
desc->status &= ~IRQ_WAKEUP;
else
--
1.5.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/