Re: [PATCH] [2/11] Add unlocked_fasync

From: Alan Cox
Date: Tue May 20 2008 - 14:46:05 EST


On Tue, 20 May 2008 08:58:30 -0700
Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> On Tue, 20 May 2008 17:28:43 +0200 (CEST)
> Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> >
> > Add a new fops entry point to allow fasync without BKL.
>
> I (again) really don't like having another entry point for this...
> it'll stay around forever rather than doing this as one step and
> move on.

Agreed entirely - all our unlocked_foo methods we got stuck with, all our
push down everyone cases we got most cases promptly fixed and the other
lock/unlocks show up clearly in grep and help embarass the
maintainer/author 8)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/