Re: [PATCH 0 of 8] x86: use PTE_MASK consistently

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> > This series has had some testing in the x86.git tree, and hasn't 
> > shown any problems.  Each patch is more or less absolutely trivial 
> > and the series is very bisectable, to help track down any problems 
> > which might arise (this area has always been a source of subtle 
> > problems).
> 
> yep, this has been problem-free in x86.git and then in -tip, we had a 
> separate x86/ptemask topic for it that we originally intended for 
> v2.6.27, and we dont mind to see it upstream now ;-)

the only delta between the 8 patches you posted here and tip/x86/ptemask 
topic is the comment below - so we are indeed on the safe side.

	Ingo

----------------->
diff --git a/include/asm-x86/pgtable.h b/include/asm-x86/pgtable.h
index 21fed4f..97c271b 100644
--- a/include/asm-x86/pgtable.h
+++ b/include/asm-x86/pgtable.h
@@ -57,6 +57,7 @@
 #define _KERNPG_TABLE	(_PAGE_PRESENT | _PAGE_RW | _PAGE_ACCESSED |	\
 			 _PAGE_DIRTY)
 
+/* Set of bits not changed in pte_modify */
 #define _PAGE_CHG_MASK	(PTE_MASK | _PAGE_PCD | _PAGE_PWT |		\
 			 _PAGE_ACCESSED | _PAGE_DIRTY)
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/