Re: [PATCH] net/ipv4/arp.c: Use the exported hex_asc fromlib/hexdump.c instead

[Harvey Harrison]

On Tue, 2008-05-20 at 15:36 -0700, David Miller wrote:
> From: Denis Cheng <crquan@xxxxxxxxx>
> Date: Mon, 19 May 2008 02:37:44 +0800
> 
> > Here the local hexbuf is a duplicate of global const char hex_asc from
> > lib/hexdump.c, except the hex letters' cases:
> > 
> > const char hexbuf[] = "0123456789ABCDEF";
> > 
> > const char hex_asc[] = "0123456789abcdef";
> > 
> > and here to print HW addresses, the hex cases are not significant.
> > 
> > Signed-off-by: Denis Cheng <crquan@xxxxxxxxx>
> 
> Applied, thanks.

You may want to use the hex_asc_hi, hex_asc_lo helpers to do the
mask/shifts for you.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/