Re: [PATCH] or51132.c: unaligned
From: Harvey Harrison
Date: Tue May 20 2008 - 20:41:45 EST
On Wed, 2008-05-21 at 01:33 +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/media/dvb/frontends/or51132.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/or51132.c b/drivers/media/dvb/frontends/or51132.c
> index c7b5785..5ed3254 100644
> --- a/drivers/media/dvb/frontends/or51132.c
> +++ b/drivers/media/dvb/frontends/or51132.c
> @@ -126,7 +126,7 @@ static int or51132_readreg(struct or51132_state *state, u8 reg)
> reg, err);
> return -EREMOTEIO;
> }
> - return le16_to_cpup((u16*)buf);
> + return buf[0] | (buf[1] << 8);
return get_unaligned_le16(buf);
> }
>
> static int or51132_load_firmware (struct dvb_frontend* fe, const struct firmware *fw)
> @@ -140,9 +140,9 @@ static int or51132_load_firmware (struct dvb_frontend* fe, const struct firmware
> dprintk("Firmware is %Zd bytes\n",fw->size);
>
> /* Get size of firmware A and B */
> - firmwareAsize = le32_to_cpu(*((u32*)fw->data));
> + firmwareAsize = le32_to_cpu(*((__le32*)fw->data));
ïfirmwareAsize = le32_to_cpup((__le32 *)fw->data);
> dprintk("FirmwareA is %i bytes\n",firmwareAsize);
> - firmwareBsize = le32_to_cpu(*((u32*)(fw->data+4)));
> + firmwareBsize = le32_to_cpu(*((__le32*)(fw->data+4)));
ïfirmwareBsize = le32_to_cpup((__le32 *)(fw->data + 4));
Cheers,
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/