Re: [PATCH] bt8xx: unaligned access
From: Al Viro
Date: Tue May 20 2008 - 20:43:28 EST
On Tue, May 20, 2008 at 05:38:43PM -0700, Harvey Harrison wrote:
> > - type = be16_to_cpup((u16*)(ee+4));
> > + type = get_unaligned_be16((__be16 *)(ee+4));
>
> The casts aren't strictly necessary here. Any reason to keep it?
I'd rather have them explicit *and* make get_unaligned_* take the pointer
of right type, so that it'd eat things like void * and __be16 *, but warn
on int * et.al. One too many brainos seen in that area...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/