Re: [PATCH] misc drivers/net endianness noise

[Al Viro]

On Tue, May 20, 2008 at 05:48:00PM -0700, Harvey Harrison wrote:
> I was contemplating an api like:
> 
> void put_le16(u16 val, __le16 *ptr)
> {
> 	*ptr = cpu_to_le16(val);
> }
> 
> which would allow the above to become:
> 
> 	if (catc->is_f5u011)
> 		put_be16(skb->len, tx_buf);
> 	else
> 		put_le16(skb->len, tx_buf);
> 
> Thoughts?

Do not grow API too much.  Mental savings on recognizing what's done are
offset by need to remember more helper functions...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/