Re: [RFC PATCH 1/3] Implement generic freeze feature

[Takashi Sato]

Hi,

Andreas Dilger wrote:
> > +static int ioctl_freeze(struct file *filp)
> > +{
> > +    struct super_block *sb = filp->f_path.dentry->d_inode->i_sb;
> > +
> > +    if (!capable(CAP_SYS_ADMIN))
> > +        return -EPERM;
> > +
> > +    /* If filesystem doesn't support freeze feature, return. */
> > +    if (sb->s_op->write_super_lockfs == NULL)
> > +        return -EINVAL;
>
> Should this be EINVAL, or EOPNOTSUPP?  Usually EINVAL means there is
> something wrong with the passed ioctl parameters (e.g. bad value),
> while EOPNOTSUPP is "operation not supported" and makes more sense.

Sounds good.
I will send new patch-set which is rebased to 2.6.26-rc3 and includes
this fix, in this weekend.

Cheers, Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/