Re: b4aa54d951d38d7a989d6b6385494ef5ea7371d7 breaks some serial configurations

[Bryan Wu]

On Wed, May 21, 2008 at 1:45 PM, Javier Herrero <jherrero@xxxxxxxxxxxxx> wrote:
> Perhaps then, at least for now, in order to quickly restore the
> functionality of the driver with other platforms and to continue having the
> 8250 support in the blackfin, would be to apply this patch, that is a bit
> ugly but at least only affects to blackfin platforms using 8250-class uarts
> :)
>

IMO, we need to revert this 8250 irq patch. Can we fix this just in
Blackfin code?
I found it was specific for our arch not for others.

-Bryan



> Regards,
>
> Javier
>
> Russell King escribió:
>>
>> On Tue, May 20, 2008 at 12:52:52PM +0200, Javier Herrero wrote:
>>>
>>> I see... would be OK to move the asm/serial.h include to its original
>>> position and to modify the asm-blackfin/serial.h in this way to avoid
>>> duplicate definition warnings, or would it be too ugly?:
>>
>> Can blackfin systems accept PCMCIA cards?  Or PCI cards?  In which case
>> you probably don't want to implement this support like this.
>>
>> A better solution may be to add some UPF_ flags to indicate the interrupt
>> polarity on a per-port basis.  Not sure I'm particularly thrilled by that
>> idea though, but other solutions I can think of inspire me even less.
>>
>
> --
> ------------------------------------------------------------------------
> Javier Herrero                            EMAIL: jherrero@xxxxxxxxxxxxxx
> HV Sistemas S.L.                          PHONE:         +34 949 336 806
> Los Charcones, 17A                        FAX:           +34 949 336 792
> 19170 El Casar - Guadalajara - Spain      WEB: http://www.hvsistemas.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/