[PATCH] capabilities: fix sys_prctl() returned uninitialized value

[Shi Weihua]

When we test kernel by the latest LTP(20080430) on ia64,
the following failure occured:
-------------------------------------
prctl01     1  PASS  :  Test Passed
prctl01     0  WARN  :  prctl() returned 2048 errno = 0 : Success
prctl01     1  PASS  :  Test Passed
prctl01     2  FAIL  :  Test Failed
-------------------------------------

We found commit 3898b1b4ebff8dcfbcf1807e0661585e06c9a91c
causes this failure by git-bisect.
And, we found *rc_p has not been initialized if switch-default 
of the function cap_task_prctl()(security/commoncap.c). When *rc_p
uninitialized, sys_prctl() will return a wrong value.

Signed-off-by: Shi Weihua <shiwh@xxxxxxxxxxxxxx> 
---
diff --git a/security/commoncap.c b/security/commoncap.c
index 5edabc7..a4b28c8 100644
--- a/security/commoncap.c
+++ b/security/commoncap.c
@@ -649,6 +649,7 @@ int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3,
 
 	default:
 		/* No functionality available - continue with default */
+		*rc_p = 0;
 		return 0;
 	}
 




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/