Re: [PATCH 04/22] ide: add ide_deprecated_find_port() helper

[Sergei Shtylyov]

Hello.

Bartlomiej Zolnierkiewicz wrote:

> * Factor out code for finding ide_hwifs[] slot from ide_register_hw()
>   to ide_deprecated_find_port().

> * Convert bast-ide, ide-cs and delkin_cb host drivers to use ide_device_add()
>   instead of ide_register_hw() (while at it drop doing "ide_unregister()" loop
>   which tries to unregister _all_ IDE interfaces if useable ide_hwifs[] slot
>   cannot be find).

   Er... this patch didn't actually drop that loop (late remark :-).

> This patch leaves us with only two ide_register_hw() users:
> - drivers/macintosh/mediabay.c
> - drivers/ide/ide.c

   I wonder whether ide_register_hw() was much good at all since it didn't 
actually permit to register chips using MMIO: you couldn't pass that info via 
'hw' and it set 'hwif->noprobe' to 0, thus giving you no chance to skip 
probing which wouldn't work anyway; for the same reason it was no good for DMA 
capable chips since you had not time to install ide_dma_check() and other DMA 
methods. Am I right here?

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/