Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocatorpass-through

[Pekka Enberg]

Christoph Lameter wrote:
> Why is it too big? Without your additions it is converting kmallocs 
> inline to get_free_pages(). That results in a simple function call with 
> two constant parameters.

Well, it's a PITA because of #include dependencies in any case. Is 
moving it out-of-line a problem?

Christoph Lameter wrote:
> The patch touches the page struct uselessly. I think the PageSlab marking 
> is useful for debugging but not for a production kernel.

Hmm, where? page_address() already references ->virtual. I suppose 
CONFIG_SLUB_DEBUG is a no no as well then so do we want to add a 
CONFIG_KSIZE_DEBUG config option...? (Btw, I removed the BUG_ON() from 
kfree() as spotted by Vegard Nossum.)

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/