Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for pageallocator pass-through

[Matt Mackall]

On Wed, 2008-05-21 at 21:26 +0300, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> 
> This patch re-uses the PG_slab flag for marking SLOB bigblock pages so we can
> check that the pointer passed ksize() was really allocated by SLOB.

Ok, first, BUG_ON is wrong.

We already know users (ie nommu memory usage reporting) are abusing this
interface. Making them blow up is unnecessary. Just give them wrong
answers. Issuing a warning might be a good idea for debugging.

Second, I'd prefer to keep this sort of debugging code out of SLOB.
SLUB is much better suited to debugging allocator abuse.

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/