Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment
From: Francois Romieu
Date: Wed May 21 2008 - 15:17:21 EST
Emmanuel Colbus <emmanuel.colbus@xxxxxxx> :
> Calling "PCI base addr 1" something that can actually lie at
> PCI_BASE_ADDR_2 is misleading. Patch follows.
>
> signed-off-by : emmanuel colbus <emmanuel.colbus@xxxxxxx>
I do not approve:
- the patch does not follow the comment style of the driver
- the comment should be removed, not silly augmented
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/