Re: initialization of static per-cpu variables
From: Rusty Russell
Date: Thu May 22 2008 - 04:20:44 EST
On Thursday 22 May 2008 04:28:02 Vegard Nossum wrote:
> Hi,
>
> I encountered this comment in kernel/softirq.c:
>
> /* Some compilers disobey section attribute on statics when not
> initialized -- RR */
> static DEFINE_PER_CPU(struct tasklet_head, tasklet_vec) = { NULL };
> static DEFINE_PER_CPU(struct tasklet_head, tasklet_hi_vec) = { NULL };
>
> So I assume it's the combination of static and whatever section
> DFINE_PER_CPU puts the variable in which is the problem.
>
> However, there's a LOT of these "static DEFINE_PER_CPU" without any
> initializer in the rest of the code, e.g.:
Yep, it was an old toolchain used by Sparc: DaveM found this one. As you say,
it's ancient: I'm happy to queue a cleanup patch now everyone is on a modern
compiler.
Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/