Re: [-mm][PATCH 2/4] Setup the memrlimit controller (v5)

From: Balbir Singh
Date: Thu May 22 2008 - 06:15:31 EST


Andrew Morton wrote:
> On Wed, 21 May 2008 20:59:48 +0530 Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
>
>> +static int memrlimit_cgroup_write_strategy(char *buf, unsigned long long *tmp)
>
> grumble. I think I requested a checkpatch warning whenever it comes
> across "tmp" or "temp". Even better would be a gcc coredump.
>

:-)

> I'm sure there's something more meaningful we could use here?

I'll send a patch to fix this.


--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/