Re: [PATCH] au1000_eth: remove useless check

[Jeff Garzik]

Francois Romieu wrote:
> The lifespan of the device covers the request_irq .. free_irq interval.
>
> The cast of a void * pointer is not needed either.
>
> Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
>
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index 3634b5f..7023d77 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -1239,12 +1239,7 @@ static int au1000_rx(struct net_device *dev)
>   */
>  static irqreturn_t au1000_interrupt(int irq, void *dev_id)
>  {
> -	struct net_device *dev = (struct net_device *) dev_id;
> -
> -	if (dev == NULL) {
> -		printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
> -		return IRQ_RETVAL(1);
> -	}
> +	struct net_device *dev = dev_id;
>  

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/