Re: [patch] provide rtc_cmos platform device

[Stas Sergeev]

Hello.

David, please CC me the replies.

David Brownell wrote:
> Well, "regression" is the wrong phrase. You've switched
> drivers (from the legacy RTC to the new one), so this is
> not the thing which worked for you before.
I am not sure how could that happen.
I am always just taking an old kernel
config and never change the options
that are not supposed to be changed.
Was the old RTC driver removed by any
chance?

>> This may also help running the
>> PNP-enabled kernel on an older PCs.
> As in, pre-PNP. That's pretty darn old!
But... I think they should still be
supported, unless it is too difficult.

> (1) On an ARM build (with no PNP configured):
OK, but unfortunately I can't help
with that. I won't touch any non-x86
arch code, so I'll simply go for
the #ifdef here, or someone else
should make the patch instead. :)

> You shouldn't define those symbols; the right values are already
> defined in <asm/mc146818rtc.h>. RTC_PORT(0) and RTC_PORT(1) are
> the symbolss to use; RTC_IRQ is already defined. All this stuff
> is used in the <asm-generic/rtc.h> code ...
OK, thanks.
I'll update the patch, in todo for
the week-end.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/