Re: [PATCH 1/1] UIO: Add a write() function to enable/disableinterrupts

[Hans J. Koch]

On Thu, May 22, 2008 at 08:47:16PM +0100, Tom Spink wrote:

Hi Tom,

> 2008/5/22 Hans J. Koch <hjk@xxxxxxxxxxxxx>:
> > Sometimes it is necessary to enable/disable the interrupt of a UIO device
> > from the userspace part of the driver. With this patch, the UIO kernel driver
> > can implement an "irqcontrol()" function that does this. Userspace can write
> > an s32 value to /dev/uioX (usually 0 or 1 to turn the irq off or on). The
> > UIO core will then call the driver's irqcontrol function.
> >
> > Signed-off-by: Hans J. Koch <hjk@xxxxxxxxxxxxx>
> 
> <snip>
> 
> Hi,
> 
> I wonder if it would be better to implement this as an ioctl,

No way. We don't want to introduce new ioctls.

> rather
> than a write to the device.  Writing to a device is a pretty generic
> thing, and this patch would tie that up to specifically controlling
> interrupts.  

UIO userspace drivers do their whole work by accessing the device's
memory directly. The purpose of the kernel part is mainly

1) allow this memory to be mapped
2) handle interrupts

We have an mmap() implementation for 1) and a read() implementation to
wait for interrupts. Now we add write to enable/disable interrupts,
which completes 2). Looks clean to me.

> An ioctl would be more appropriate, IMO, as you are
> issuing a controlling command, i.e. disable or enable interrupts.
> 
> By the way, I have absolutely no idea how the UIO driver works, other
> than reading http://lwn.net/Articles/232575/

You could read the docs that come with the kernel sources:
Documentation/DocBook/uio_howto

Thanks,
Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/