Re: [PATCH 1/1] UIO: Add a write() function to enable/disable interrupts

[Uwe Kleine-König]

Hello Hans,

> > Otherwise the patch looks fine.
> 
> Thanks for your review! Could you add your Signed-off-by?
I don't consider my feed back valueable enough for a Signed-off-by, but
you can get an ...

> From: Hans J. Koch <hjk@xxxxxxxxxxxxx>
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>,
> 	Jan Altenberg <jan.altenberg@xxxxxxxxxxxxx>,
> 	Thomas Gleixner <tglx@xxxxxxxxxxxxx>,
> 	Uwe Kleine-König <Uwe.Kleine-Koenig@xxxxxxxx>,
> 	Magnus Damm <magnus.damm@xxxxxxxxx>
> Subject: UIO: Add write function to allow irq masking
> Date: Thu, Fri, 23 May 2008 13:50:14 +0200
> 
> Sometimes it is necessary to enable/disable the interrupt of a UIO device
> from the userspace part of the driver. With this patch, the UIO kernel driver
> can implement an "irqcontrol()" function that does this. Userspace can write
> an s32 value to /dev/uioX (usually 0 or 1 to turn the irq off or on). The
> UIO core will then call the driver's irqcontrol function.
> 
> Signed-off-by: Hans J. Koch <hjk@xxxxxxxxxxxxx>
Acked-by: Uwe Kleine-König <Uwe.Kleine-Koenig@xxxxxxxx>,

Best regards
Uwe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/