Re: [i2c] [PATCH] i2c: Push ioctl BKL down into the i2c code
From: Jon Smirl
Date: Fri May 23 2008 - 10:01:18 EST
On 5/23/08, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 23 May 2008 09:35:45 +0200
> Jean Delvare <khali@xxxxxxxxxxxx> wrote:
>
> > Hi Alan,
> >
> > On Thu, 22 May 2008 22:23:27 +0100, Alan Cox wrote:
> > > Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
> > >
> >
> > Description of what the patch does and why it is needed, please. I
> > can't apply it without that. My first impression is a patch making the
> > code bigger and more complex with no obvious benefit ;)
Alan, for people not familiar with the BKL attaching a write up or
pointer to the patches on the recommended ways to convert these locks
to something else would help. Some embedded developers won't know what
to do with these patches and they don't follow lkml.
> It pushes the BKL down into the i2c driver. The intention is to remove
> the big kernel lock ioctl method from the file_operations structure so
> that we can work on getting rid of the big kernel lock for good. It's one
> of a series of patches that give me an x86-32 tree with no ->ioctl method
> at all.
>
> Similar activity is going on for the other calls made under the BKL the
> goal being to push it down into drivers and then eliminate it.
>
>
>
> _______________________________________________
> i2c mailing list
> i2c@xxxxxxxxxxxxxx
> http://lists.lm-sensors.org/mailman/listinfo/i2c
>
--
Jon Smirl
jonsmirl@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/