Re: [patch 06/14] hfsplus: remove hfsplus_permission()

[Roman Zippel]

Hi,

On Thu, 22 May 2008, Miklos Szeredi wrote:

> > As I said to allow lookup on files.
> 
> That requires a quite bit more support from the VFS than just allowing
> lookup to work on regular files without x bits.  You'll have big
> trouble with hard links for example: the VFS doesn't like non-leaf
> dentries to be aliased.
> 
> Besides hfsplus_permission() did not differentiate between execve on
> the file and lookup on that file, allowing both.  Which is obviously
> wrong.

I'm not saying it's perfect. I wished there was a MAY_LOOKUP to clearly 
differentiate both cases.
For now I'd rather keep it as it is and I'll look into it when I find the 
time.

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/