Re: [PATCH 1/3] firmware: allow firmware files to be built into kernel image

From: Takashi Iwai
Date: Fri May 23 2008 - 11:19:41 EST


At Fri, 23 May 2008 15:58:31 +0100,
David Woodhouse wrote:
>
> On Fri, 2008-05-23 at 16:53 +0200, Takashi Iwai wrote:
> > This looks like a nice cleanup. It'd be nicer if we can skip vmalloc
> > and duplication of the image for static binaries.
>
> Yeah, I thought about that. I was slightly concerned that drivers might
> actually try to _modify_ the firmware they loaded, though. As it is,
> there's no fundamental reason why they shouldn't do that.

Hm, but request_firmware() returns the const pointer. It implies that
the caller shouldn't change the content, doesn't it?

I cannot guarantee that there must be no misbehaving drivers,
though...


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/