Re: Linux 2.6.26-rc4

[Jeff Garzik]

Carl-Daniel Hailfinger wrote:
> On 27.05.2008 12:35, Jeff Garzik wrote:
> > Carl-Daniel Hailfinger wrote:
> > > New code should look like
> > > static struct pci_device_id ck804xrom_pci_tbl[] = {
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0051), .driver_data =
> > > DEV_CK804 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0360), .driver_data =
> > > DEV_MCP55 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0361), .driver_data =
> > > DEV_MCP55 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0362), .driver_data =
> > > DEV_MCP55 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0363), .driver_data =
> > > DEV_MCP55 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0364), .driver_data =
> > > DEV_MCP55 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0365), .driver_data =
> > > DEV_MCP55 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0366), .driver_data =
> > > DEV_MCP55 },
> > >     { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0367), .driver_data =
> > > DEV_MCP55 },
> > >     { 0, }
> > > };
> >
> > Actually, more like
> >
> >     { PCI_VDEVICE(NVIDIA, 0x0367), DEV_MCP55 },
>
> AFAICS that would reintroduce the bug.

Look closely.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/