Re: [PATCH] scsi: remove CDROM not ready printk

[Andrew Morton]

On Tue, 27 May 2008 15:02:43 -0400 (EDT) Jerry Stralko <gerb.stralko@xxxxxxxxx> wrote:

> Hello,

let's cc a scsi list which exists ;)

>    This printk was spamming my dmesg and /var/log/message.  Is there a 
> reason we have this printk?  Can we simply remove it?
> 
> 
> Signed-off-by: Jerry Stralko <gerb.stralko@xxxxxxxxx>
> ---
> 
> 
> diff --git a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
> index ae87d08..c37fb1c 100644
> --- a/drivers/scsi/sr_ioctl.c
> +++ b/drivers/scsi/sr_ioctl.c
> @@ -238,8 +238,6 @@ int sr_do_ioctl(Scsi_CD *cd, struct packet_command *cgc)
>   					break;
>   				}
>   			}
> -			if (!cgc->quiet)
> -				printk(KERN_INFO "%s: CDROM not ready.  Make sure there is a disc in the drive.\n", cd->cdi.name);
>   #ifdef DEBUG
>   			scsi_print_sense_hdr("sr", &sshdr);
>   #endif

The answer may be that you need to enable cgc->quiet.  If that is
user-enableable - I can't work out how from a quick grep.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/