Re: [PATCH 2 of 5] xn/blkfront: Add the CDROM_GET_CAPABILITY ioctlto blkfront

[Jeremy Fitzhardinge]

Jeff Garzik wrote:
> Jeremy Fitzhardinge wrote:
> > +    case CDROM_GET_CAPABILITY: {
> > +        struct gendisk *gd = info->gd;
> > +        if (gd->flags & GENHD_FL_CD)
> > +            return 0;
> > +        return -EINVAL;
> > +    }
>
>
> Surely you can come up with a better implementation than this?  It's 
> just a bitmask returned to userspace...

Unfortunately the Xen block driver interface doesn't seem to pass 
through any capabilities of the underlying CDROM device, so there's not 
much to return.  I suspect this is primarily a hack to make installers a 
bit happier installing off a Xen VBD rather than because real programs 
will use this in earnest.

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/