Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB

[Pekka Enberg]

On Sun, Jun 01, 2008 at 12:13:02PM +0300, Pekka J Enberg wrote:
> > I mean, assuming the BUG_ON bits are bogus, then we should always pass the 
> > pointer to the allocator. I audited most of the callers and they all seem 
> > to be really just using kmalloc() for allocation anyway.
> >
> > What do you think?

Paul Mundt wrote:
> Isn't this what my original patch did? ;-)

Oh, almost, you had this bit in ksize() of SLAB:

+	page = virt_to_head_page(objp);
+	if (unlikely(!PageSlab(page)))
+		return PAGE_SIZE << compound_order(page);

Did you actually need it for something?

		Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/