Re: [2.6.26 patch] fat_valid_media() isn't for userspace

[H. Peter Anvin]

OGAWA Hirofumi wrote:
> Yes. This is new one, so it shouldn't have any users of that.
> Looks more better. Thanks.

The other thing about this header that needs to be fixed is the 
definition of the following ioctls:

#define VFAT_IOCTL_READDIR_BOTH         _IOR('r', 1, struct dirent [2])
#define VFAT_IOCTL_READDIR_SHORT        _IOR('r', 2, struct dirent [2])

"struct dirent" is a kernel type here, but is a **different type** in 
userspace!  This means both the structure and the IOCTL number is wrong!

We need to make this either __kernel_dirent_t[*] or something like 
struct __msdos_fs_dirent.

	-hpa

[*] Yes, typedefs suck, but unfortunately C doesn't allow aliases in the 
structure tag namespace.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/