Re: [PATCH] USB: don't use reset-resume if drivers don't support it

From: Greg KH
Date: Tue Jun 10 2008 - 17:35:43 EST


On Tue, Jun 10, 2008 at 02:59:43PM -0400, Alan Stern wrote:
> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>
> This patch tries to identify which devices are able to accept
> reset-resume handling, by checking that there is at least one
> interface driver bound and that all of the drivers have a reset_resume
> method defined. If these conditions don't hold then during resume
> processing, the device is logicall disconnected.
>
> This is only a temporary fix. Later on we will explicitly unbind
> drivers that can't handle reset-resumes.
>
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
>
> ---
>
> Greg:
>
> This patch really is a temporary fix meant only for 2.6.26. There
> already are changes in the gregkh development tree which clash with
> this, and I intend to submit separately a real fix for the problem
> (i.e., unbind drivers that don't have suspend, resume, reset_resume,
> pre_reset, or post_reset methods, as needed).
>
> Is there any way this can be added to 2.6.26-rc while leaving it out of
> the gregkh tree?

Yes I can, but note, the gregkh tree gets rebased on what goes into -rc,
so hopefully it will not conflict too much :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/