Re: [RFC][PATCH] kmemcheck: divide and conquer

[Ingo Molnar]

-tip testing found a build failure with kmemcheck:

include/asm/string_32.h:320:1: warning: "memset" redefined
include/asm/string_32.h:245:1: warning: this is the location of the previous definition

arch/x86/mm/kmemcheck/smp.c: In function 'kmemcheck_pause_allbutself':
arch/x86/mm/kmemcheck/smp.c:59: error: 'NMI_VECTOR' undeclared (first use in this function)
arch/x86/mm/kmemcheck/smp.c:59: error: (Each undeclared identifier is reported only once
arch/x86/mm/kmemcheck/smp.c:59: error: for each function it appears in.)

with this config:

  http://redhat.com/~mingo/misc/config-Mon_Jun_16_04_15_22_CEST_2008.bad

the patch below fixes the build failure, but note that there are lots of 
those memset redefined warnings with that config as well.

	Ingo

------------>
commit 36bdad27f868eba1d17e6d9dc1cbb6794361d541
Author: Ingo Molnar <mingo@xxxxxxx>
Date:   Mon Jun 16 07:11:37 2008 +0200

    kmemcheck: fix build error
    
    fix:
    
    arch/x86/mm/kmemcheck/smp.c: In function 'kmemcheck_pause_allbutself':
    arch/x86/mm/kmemcheck/smp.c:59: error: 'NMI_VECTOR' undeclared (first use in this function)
    arch/x86/mm/kmemcheck/smp.c:59: error: (Each undeclared identifier is reported only once
    arch/x86/mm/kmemcheck/smp.c:59: error: for each function it appears in.)
    
    Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

diff --git a/arch/x86/mm/kmemcheck/smp.c b/arch/x86/mm/kmemcheck/smp.c
index c4ff615..cd17ddf 100644
--- a/arch/x86/mm/kmemcheck/smp.c
+++ b/arch/x86/mm/kmemcheck/smp.c
@@ -5,6 +5,7 @@
 #include <mach_ipi.h>
 
 #include "smp.h"
+#include <asm/irq_vectors.h>
 
 static spinlock_t nmi_spinlock;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/