Re: [Patch 002/005](memory hotplug) align memmap to page size

[Andy Whitcroft]

On Mon, Apr 07, 2008 at 09:46:19PM +0900, Yasunori Goto wrote:
> To free memmap easier, this patch aligns it to page size.
> Bootmem allocater may mix some objects in one pages.
> It's not good for freeing memmap of memory hot-remove.
> 
> 
> Signed-off-by: Yasunori Goto <y-goto@xxxxxxxxxxxxxx>
> 
> ---
>  mm/sparse.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: current/mm/sparse.c
> ===================================================================
> --- current.orig/mm/sparse.c	2008-04-07 19:18:50.000000000 +0900
> +++ current/mm/sparse.c	2008-04-07 20:08:13.000000000 +0900
> @@ -265,8 +265,8 @@
>  	if (map)
>  		return map;
>  
> -	map = alloc_bootmem_node(NODE_DATA(nid),
> -			sizeof(struct page) * PAGES_PER_SECTION);
> +	map = alloc_bootmem_pages_node(NODE_DATA(nid),
> +		       PAGE_ALIGN(sizeof(struct page) * PAGES_PER_SECTION));
>  	return map;
>  }
>  #endif /* !CONFIG_SPARSEMEM_VMEMMAP */

Ahh ok, we do makes sure the mmap uses up the rest of the space.  That
though is a shame as we cannot slip the usemap in the end of the space
any more (assuming we could).

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/