Re: [PATCH] x86: merge setup_memory_map with e820

[Yinghai Lu]

On Tue, Jun 17, 2008 at 9:04 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> Glauber Costa wrote:
>>>
>>> +       boot_params.e820_entries = new_nr;
>>> +       if (copy_e820_map(boot_params.e820_map, boot_params.e820_entries)
>>> < 0) {
>>> +#ifdef CONFIG_X86_64
>>> +               early_panic("Cannot find a valid memory map");
>>> +#else
>>
>> Can't this be made dependant on HIGHMEM instead of X86_64? It seems
>> high-memory dependant anyway. Also, are you sure
>> this code that maps into himem would work with HIGHMEM disabled anyway?

that is behavoir before merge.

>>
>
> Uhm... x86-64 and HIGHMEM are mutually exclusive.
>
> Either way, it shouldn't be dependent on anything; there is no reason why
> the #else clause can't be applied to both.

remove the early_panic?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/