Re: [stable] [PATCH 2/2] xen: don't drop NX bit

[Chris Wright]

* Greg KH (greg@xxxxxxxxx) wrote:
> On Mon, Jun 16, 2008 at 03:01:56PM -0700, Jeremy Fitzhardinge wrote:
> > When converting the pfn/mfn in a pagetable entry, make sure we mask
> > out the protection flags properly.  Formerly, this code was losing the
> > NX bit, and not dealing with extra Xen-defined software flags in ptes.
> > 
> > Because NX is now enforced properly, we must put the hypercall page
> > into the .text segment so that it is executable.
> > 
> > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> > Cc: Stable Kernel <stable@xxxxxxxxxx>
> 
> While it's great that you tell the stable people about this, but is it
> realistic?  Is anyone using Xen as contained in the mainline kernel
> these days?
> 
> If a distro were to be based on 2.6.25 and we take this patch, they will
> just revert it back out due to their very large Xen patchset they apply
> on top to get a "working" Xen version, right?

Fedora uses proper pv-ops for Xen.  It's a good -stable candidate.

Acked-by: Chris Wright <chrisw@xxxxxxxxxxxx>

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/